Front page | perl.perl5.porters |
Postings from November 2011
> From: Ãvar Arnfjörð Bjarmason
> On Fri, Nov 25, 2011 at 17:54, Konovalov, Vadim wrote:
>
> > I am exactly opposed to this change.
> >
> > 1. "use warnings;" requires newer perl that perl5db.pl supports
> > 2. anyway, the debugger should behave equally good on
> strict-enabled and strict-
> > disabled programs.
> > Introducing new bugs with your proposal is NOT GOOD.
>
> This whole line of argument is ridiculous, and it's gone on for way
> too long.
As further discussion revelaed, my fears were valid.
>
> * Someone's willing to volunteer to fix up a part of our code.
>
> * Their changes could be a good improvement to the perl debugger.
>
> Sure it could break, but let's wait until we actually have patches to
> review before we talk about that. There's no inherent reason for why
> the debugger using strict/warnings would break programs being
> debugged.
The point is a bit different.
I am welcoming good and thougthful applying of modern techniques
to any perl5 sources and perl5db in particular.
To say, there exists already a seemingly safe way on doing this.
(I mean the way Jesse suggested: a number of smaller changes
that introduce strictness without actual "use strict;" as of yet, with
actual "use strict;" further on the way)
I am very much welcoming this approach.
Namely because with this ./lib/perl5db.pl file a special care should
be taken.
What I am against - just doing some mechanical work that will
certainly break the debugger.
Initial patch had many such blocks:
{
no strict 'refs';
....
}
one of them appeared to be questionable - I asked for comment on one
of it and author of the patch had difficulties to correctly explain on
what have happened on the mentioned piece of code.
>
> A volunteer-driven software project doesn't work if we waste an
> inordinate amount of time debating what every potential change could
> *possibly* entail before we actually see that change.
patching of this particular deserves this debate because it needs
special care to be taken.
>
> So let's see what the change will look like once it's done, and be
> pleased that someone's willing to volunteer to work on the perl
> codebase.
But let this work not break parts of it.
I am welcoming modernization.
Regards,
Vadim.
Thread Previous
|
Thread Next