On Aug 3, 2011, at 11:42 PM, Brian Fraser wrote: > On Wed, Aug 3, 2011 at 11:00 AM, Nicholas Clark <nick@ccl4.org> wrote: > Ooooh, that doesn't seem to be tested anywhere. Fortunately Class::C3 on > > CPAN seems to have a test that that we can "borrow". I mean imitate. > Imitation being the sincerest form of flattery. > > (Assuming that you haven't written one between then and now. Likely this > belongs somewhere in ext/mro/t/) > > > I approve of such gallantry course of action! But rafl did write a test a couple of weeks back, though I guess it didn't make it into blead. I'll add it to ext/mro/t/ unless someone wants to commit it earlier? I’ll try and get to it some time.... > > Also, I think that none of the "*dir() attempted on invalid dirhandle %s" warnings are tested anywhere, so if someone gets around adding the mro test, maybe add those too? Triggering the warning itself is trivial, but I assume the portability concerns are not: perl -we 'opendir my $dir, "."; closedir $dir; seekdir $dir, 0;' $ perl -we 'no warnings "once"; seekdir *foo, 0' seekdir() attempted on invalid dirhandle foo at -e line 1.Thread Previous | Thread Next