Front page | perl.perl5.porters |
Postings from December 2010
On Mon, Dec 13, 2010 at 02:41:20PM -0800, David Golden wrote:
> I see this change as the first step towards future improvements.
I see that this change broke the tests. I have fixed it.
I know that everyone means well, but *please* could everyone mean well
MORE CAREFULLY.
[Yes, you may well be irritated that the only feedback you get is this.
*I* am irritated too, but for my reason]
In particular, please could everyone before pushing, at least run
make test_porting
I'm frustrated by how often the tests are broken for trivial, avoidable reasons
because we're not *using* the basic precautions that we already have.
And I'm frustrated about how often *I* am the person fixing them.
Yes, it matters. Because some of the smokers on the more obscure platforms
have a 1 or 2 day cycle, and if they chance to hit upon a duff commit, then
the most recent smoke report becomes a "FAIL". At which point, if you want to
see whether anything is "actually" broken, the subject line is not enough,
you start having to read the actual message and discount "known" failures, and
it's a lot more work.
Nicholas Clark
Thread Previous
|
Thread Next