Front page | perl.perl5.porters |
Postings from October 2010
On Sat, Oct 30, 2010 at 02:40:36AM +0200, George Greer wrote:
> Fix Math::BigInt::FastCalc build under Win32 with croak_xs_usage().
> -----------------------------------------------------------------------
>
> Summary of changes:
> dist/Math-BigInt-FastCalc/FastCalc.xs | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/dist/Math-BigInt-FastCalc/FastCalc.xs b/dist/Math-BigInt-FastCalc/FastCalc.xs
> index dfff9f4..0d67eb7 100644
> --- a/dist/Math-BigInt-FastCalc/FastCalc.xs
> +++ b/dist/Math-BigInt-FastCalc/FastCalc.xs
> @@ -37,7 +37,7 @@ PROTOTYPES: DISABLE
> BOOT:
> {
> if (items < 4)
> - S_croak_xs_usage(aTHX_ cv, "package, version, base_len, base");
> + croak_xs_usage(aTHX_ cv, "package, version, base_len, base");
There is a function S_croak_xs_usage() defined in that code:
STATIC void
S_croak_xs_usage(pTHX_ const CV *const cv, const char *const params);
Perl_croak_xs_usage isn't available on older perls, and this is a dual life
module.
What was the actual build error?
Really, the code should continue to use the static function, else it's not
going to work as a dual life module with older perls.
Nicholas Clark
Thread Next