Re: [PATCH] Support B::Generate and B::C

Florian Ragwitz schrieb:
> Reini Urban<rurban@x-ray.at>  writes:
>> It is already disabled, and most importantly not tested.  I'm trying
>> now to improve test coverage of the API.
>
> The missing tests are quite a problem really. Earlier this month I was
> proposing a patch to make newPADOP private. You spoke up against it,
> claiming that B::Generate actually needed it. After looking at the code,
> it turns out it only needs it to reimplement newGVOP, which is really
> unnecessary.
>
> I'd love to provide a patch removing code, and making it use newGVOP,
> thereby eliminating one reason to not drop newPADOP from the public API,
> but I don't have a way to make sure B::Generate is still working as
> expected, given there are almost no tests :-(

I don't really care for B::Generate as it is no love child of mine.
I never used it. I just want to keep it alive.

If you come with something better I'll use that of course.

Tests: I'm writing those now. Coverage is incredibly low.
-- 
Reini Urban

• [PATCH] Support B::Generate and B::C by Reini Urban
• [PATCH v2] Support B::Generate and B::C by Reini Urban
• Re: [PATCH v2] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Jim Cromie
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Jim Cromie
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Jim Cromie
• Re: [PATCH] Support B::Generate and B::C by Ben Morrow
• Re: [PATCH] Support B::Generate and B::C by demerphq
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Jim Cromie
• Re: [PATCH] Support B::Generate and B::C by Ben Morrow
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Florian Ragwitz
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Leon Timmermans
• Re: [PATCH] Support B::Generate and B::C by Elizabeth Mattijsen
• Re: [PATCH] Support B::Generate and B::C by Jim Cromie
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Another [PATCH] i_opt (was: Support B::Generate and B::C) by Reini Urban
• Re: Another [PATCH] i_opt (was: Support B::Generate and B::C) by Nicholas Clark
• Re: Another [PATCH] i_opt by Reini Urban
• Re: Another [PATCH] i_opt (was: Support B::Generate and B::C) by Nicholas Clark
• Re: Another [PATCH] i_opt (was: Support B::Generate and B::C) by Craig A. Berry
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Leon Timmermans
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Bram
• Re: [PATCH] Support B::Generate and B::C by Reini Urban
• Re: [PATCH] Support B::Generate and B::C by Ben Morrow
• Re: [PATCH] Support B::Generate and B::C by Tim Bunce
• Re: [PATCH] Support B::Generate and B::C by Nicholas Clark
• Managing the visibility and use of perl internals by Tim Bunce
• Re: Managing the visibility and use of perl internals by Nicholas Clark
• Re: Managing the visibility and use of perl internals by Tim Bunce
• Re: Managing the visibility and use of perl internals by Reini Urban