develooper Front page | perl.perl5.porters | Postings from March 2010

Re: [perl #73382] Support cygwin-1.7 mount, t/lib/cygwin.t regression

Thread Previous
From:
Rafael Garcia-Suarez
Date:
March 8, 2010 01:00
Subject:
Re: [perl #73382] Support cygwin-1.7 mount, t/lib/cygwin.t regression
Message ID:
b77c1dce1003080059g20046565qa9d579d793099415@mail.gmail.com
On 7 March 2010 11:20, cygwin@cygwin.com <perlbug-followup@perl.org> wrote:
> We need to support the new cygwin-1.7 mount syntax
> for the testsuite.
>
> >From b9a3b2d2937e98405c1c888722540f53d81ffeb7 Mon Sep 17 00:00:00 2001
> From: Reini Urban <rurban@x-ray.at>
> Date: Thu, 4 Mar 2010 17:09:35 +0000
> Subject: [PATCH] Support cygwin-1.7 mount
>
> ---
>  t/lib/cygwin.t |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/t/lib/cygwin.t b/t/lib/cygwin.t
> index 497f381..e4fde17 100644
> --- a/t/lib/cygwin.t
> +++ b/t/lib/cygwin.t
> @@ -44,12 +44,12 @@ chdir($pwd);
>  is(Cygwin::win_to_posix_path($winpath, 1), "/", "win to absolute posix path");
>
>  my $mount = join '', `/usr/bin/mount`;
> -$mount =~ m|on /usr/bin type .+ \((\w+mode)[,\)]|m;
> -my $binmode = $1 eq 'binmode';
> +$mount =~ m|on /usr/bin type .+ \((\w+)[,\)]|m;
> +my $binmode = $1 =~ /binmode|binary/;
>  is(Cygwin::is_binmount("/"),  $binmode ? 1 : '', "check / for binmount");

Since the patch only makes the test more forgiving, and is
platform-specific, I applied it to bleadperl now, thanks.

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About