On Mon, Nov 02, 2009 at 10:41:05PM +0100, Marcus Holland-Moritz wrote:
> >
> > > Note that there was already some logic in buildperl.pl to handle
> > > parts of that <command-line> / <built-in> problem by actually
> > > patching the makefiles after Configure.
> >
> > Ooh. I must admit I don't remember trying to run buildperl.pl without
> > the modifications. So maybe my patches are obsolete?
> >
> > Maybe I should run my whole test script again, just to check that it
> > works without my patches? Or that some of the patches can be removed?
>
> It would be nice if you could test without.
I just did. None of the following compiles:
> I *think* your patches
> that fix the quoting issue have to be applied anyway.
Indeed, the error I see is usually:
./makedepend: 1: Syntax error: Unterminated quoted string
> But the
> <command-line> / <built-in> stuff can probably be addressed in
> build_and_install() by adding more cases to the sed call.
OK. So I'll refine my changes by adding the quoting patch and ensuring
the sed call does everything that's needed.
Should I send a patch against blead, or against the latest release on
CPAN or against some other repository?
--
Philippe Bruhat (BooK)
When it is time for voting- / In the West or in the East-
Why must we always settle for- / The man we hate the least?
(Intro poem to Groo The Wanderer #108 (Epic))
Thread Previous
|
Thread Next