develooper Front page | perl.perl5.porters | Postings from October 2009

Re: A plethora of patches

Thread Previous
From:
David Golden
Date:
October 31, 2009 04:56
Subject:
Re: A plethora of patches
Message ID:
5d4beb40910310456x3f5abb81p5ed79f51356c6ea0@mail.gmail.com
On Sat, Oct 31, 2009 at 7:18 AM, demerphq <demerphq@gmail.com> wrote:
> +If you are working with a git clone of the Perl repository, you will want to
> +create a branch for your changes. This will make creating a proper patch much
> +simpler. See the L<perlrepository> for details on how to do this.
>
> Is not ideal imo.  It actually doesnt make creating a proper patch
> simpler, and might even make it more complex.
>
> Unfortunately I can think of a better replacement. :-(

s/simpler/easier/

  $ git co -b my-fix blead
  [hack hack hack]
  [configure/make/test]
  $ git commit -am "fixed yadda yadda"
  $ git format-patch blead
  $ git send-email 0001...

Maybe clarify that it makes *sending* a proper patch easier, where
"proper patch" is one that a committer can apply with less effort.

What *really* is easier (though horribly complex under the hood) is
working on a fix in small commit increments, then squashing into a
single commit, plus rebasing onto the tip of blead if substantial
changes have happened.  That's ugly to do without a branch.

My bikeshed is green,
David

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About