develooper Front page | perl.perl5.porters | Postings from October 2009

Re: [PATCH] Convert all Pod::Simple files to Unix line endings.

Thread Previous | Thread Next
From:
Steve Hay
Date:
October 28, 2009 15:03
Subject:
Re: [PATCH] Convert all Pod::Simple files to Unix line endings.
Message ID:
db930dff0910281503r6f1e5c32tcdad253c96dba971@mail.gmail.com
2009/10/28 David E. Wheeler <david@kineticode.com>:
> In response to Steve Hay's report in
> [RT #50922](https://rt.cpan.org/Ticket/Display.html?id=50922).
>
> ---
>  cpan/Pod-Simple/t/corpus/2202jp.txt            |  202 +++++++++++-----------
>  cpan/Pod-Simple/t/corpus/2202jpx.txt           |  202 +++++++++++-----------
>  cpan/Pod-Simple/t/corpus/2202jpy.txt           |  202 +++++++++++-----------
>  cpan/Pod-Simple/t/corpus/2202jpz.txt           |   28 ++--
>  cpan/Pod-Simple/t/corpus/cp1256.txt            |   78 +++++-----
>  cpan/Pod-Simple/t/corpus/fet_cont.txt          |   44 +++---
>  cpan/Pod-Simple/t/corpus/fet_dup.txt           |  112 ++++++------
>  cpan/Pod-Simple/t/corpus/iso6.txt              |   78 +++++-----
>  cpan/Pod-Simple/t/corpus/koi8r.txt             |  102 ++++++------
>  cpan/Pod-Simple/t/corpus/laozi38.txt           |   74 ++++----
>  cpan/Pod-Simple/t/corpus/laozi38b.txt          |   74 ++++----
>  cpan/Pod-Simple/t/corpus/laozi38p.pod          |   92 +++++-----
>  cpan/Pod-Simple/t/corpus/lat1fr.txt            |   76 ++++----
>  cpan/Pod-Simple/t/corpus/lat1frim.txt          |   72 ++++----
>  cpan/Pod-Simple/t/corpus/nonesuch.txt          |   22 ++--
>  cpan/Pod-Simple/t/corpus/pasternak_cp1251.txt  |  216 ++++++++++++------------
>  cpan/Pod-Simple/t/corpus/plain.txt             |   40 +++---
>  cpan/Pod-Simple/t/corpus/plain_explicit.txt    |   44 +++---
>  cpan/Pod-Simple/t/corpus/plain_latin1.txt      |   48 +++---
>  cpan/Pod-Simple/t/corpus/plain_utf8.txt        |   48 +++---
>  cpan/Pod-Simple/t/corpus/polish_utf8.txt       |  138 ++++++++--------
>  cpan/Pod-Simple/t/corpus/s2763_sjis.txt        |   96 ++++++------
>  cpan/Pod-Simple/t/corpus/thai_iso11.txt        |  128 +++++++-------
>  cpan/Pod-Simple/t/corpus2/polish_utf8_bom.txt  |  134 ++++++++--------
>  cpan/Pod-Simple/t/corpus2/polish_utf8_bom2.txt |  134 ++++++++--------
>  25 files changed, 1242 insertions(+), 1242 deletions(-)
>
[...]

Thanks for the quick turnaround on this.

However, since there is not yet a new CPAN release, I'm not sure if
this should be applied yet or not. What will Porting/Maintainers.pl
say? Neither the current 3.09 nor the forthcoming 3.10 would be
correct.

Also, I'm unable to apply the patch myself anyway. Git sadly doesn't
work entirely smoothly on Win32. I have to run any patches through
dos2unix before 'git am' will handle them, but doing that presumably
renders the changes somewhat ineffective, which could explain why 'git
am' won't apply this patch even after dos2unixing it. I also tried
once more without dos2unixing it first, but that doesn't work either
:-(

So hopefully someone else can apply the patch (but possibly not until
3.10 is out?).

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About