Front page | perl.perl5.porters |
Postings from October 2009
Re: [PATCH] Bring Pod::Simple up to 3.09 as on CPAN.
Thread Previous
|
Thread Next
From:
Craig A. Berry
Date:
October 28, 2009 11:27
Subject:
Re: [PATCH] Bring Pod::Simple up to 3.09 as on CPAN.
Message ID:
c9ab31fc0910281127x509cfe95pebe16f444c78d98a@mail.gmail.com
On Tue, Oct 27, 2009 at 2:09 PM, David E. Wheeler <david@kineticode.com> wrote:
> diff --git a/cpan/Pod-Simple/t/search20.t b/cpan/Pod-Simple/t/search20.t
> index 3022b36..52c6c36 100644
> --- a/cpan/Pod-Simple/t/search20.t
> +++ b/cpan/Pod-Simple/t/search20.t
> @@ -69,16 +69,12 @@ print $p;
>
> {
> my $names = join "|", sort values %$where2name;
> -skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0,
> - $names,
> - "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik";
> +ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik";
> }
>
> {
> my $names = join "|", sort keys %$name2where;
> -skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0,
> - $names,
> - "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik";
> +ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik";
> }
>
> ok( ($name2where->{'squaa'} || 'huh???'), '/squaa\.pm$/');
> diff --git a/cpan/Pod-Simple/t/search22.t b/cpan/Pod-Simple/t/search22.t
> index 6e6d662..05157b7 100644
> --- a/cpan/Pod-Simple/t/search22.t
> +++ b/cpan/Pod-Simple/t/search22.t
> @@ -71,17 +71,13 @@ print $p;
> {
> print "# won't show any shadows, since we're just looking at the name2where keys\n";
> my $names = join "|", sort keys %$name2where;
> -skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0,
> - $names,
> - "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik";
> +ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Vliff|perlflif|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Wowo|zikzik";
> }
>
> {
> print "# but here we'll see shadowing:\n";
> my $names = join "|", sort values %$where2name;
> -skip $^O eq 'VMS' ? '-- case may or may not be preserved' : 0,
> - $names,
> - "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Glunk|hinkhonk::Vliff|hinkhonk::Vliff|perlflif|perlthng|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo|zikzik";
> +ok $names, "Blorm|Suzzle|Zonk::Pronk|hinkhonk::Glunk|hinkhonk::Glunk|hinkhonk::Vliff|hinkhonk::Vliff|perlflif|perlthng|perlthng|perlzuk|squaa|squaa::Glunk|squaa::Vliff|squaa::Vliff|squaa::Vliff|squaa::Wowo|zikzik";
>
> my %count;
> for(values %$where2name) { ++$count{$_} };
Any particular reason these skips were taken out? From the smoke
reports it sure looks as though they are still needed (and probably
more like them, but I'd at least like not to slip backwards).
Thread Previous
|
Thread Next