develooper Front page | perl.perl5.porters | Postings from May 2009

Resend, lib/file/compare.t patch for VMS.

Thread Next
From:
John E. Malmberg
Date:
May 30, 2009 10:39
Subject:
Resend, lib/file/compare.t patch for VMS.
Message ID:
4A216F59.1040704@qsl.net
The lib/file/compare.t test has never been correct for VMS, but the bugs 
where mostly hidden until testing on a ODS-5 volume with that allows 
filenames with more characters in them than VMS traditionally allows. 
This is known as EFS_CHARSET mode.

This also exposes that the vmsify() routine in the traditional VMS mode 
is not matching how the C library in VMS internally implements the 
equivalent function.

I am not sure that we want to change the vmsify() function traditional 
VMS mode behavior at this time.

It also exposes that the flush() operation is a no-op on the VMS 
platform, which is something that needs to be fixed.

This issue with flush() has shown up before, but the test was modified 
to not use that algorithm.

The DECC$FILE_SHARING feature needs to be active for this test to work 
when the EFS_CHARSET mode is on.  By default DECC$FILE_SHARING is off, 
and so far none of the other Perl tests need it enabled, even when in 
UNIX compatible mode.


This patch fixes the lib/file/compare.t test to actually work the way it 
was intended to on VMS when VMS is in the traditional mode, and not 
leave extra files behind in SYS$SCRATCH:

On VMS SYS$SCRATCH: by default behaves like a user private copy of /tmp 
on Unix.

This patch also adds diagnostics so that explains what is wrong when VMS 
is run in the EFS_CHARSET mode.  As DECC$FILE_SHARING is not normally 
active, it has a check to skip the tests that require it.

The last e-mail from Craig that I saw about the initial submission where 
he was not sure about the extra diagnostics, but was going to look it 
over, and I did not see a response to my more detailed post about patch 
and why these diagnostics are needed.

Regards,
-John
wb8tyw@qsl.net
Personal Opinion Only



Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About