On Wed, Feb 18, 2009 at 11:31:25PM +0000, David Cantrell wrote: > On Wed, Feb 18, 2009 at 07:18:43AM -0500, David Golden wrote: > > On Wed, Feb 18, 2009 at 6:41 AM, David Cantrell <david@cantrell.org.uk> wrote: > > > I'd be happy to knock up a patch to do that if no-one else does. > > Do it. > > Done it! Here's a diff -ruN against 5.10.0. > > http://hetzner.barnyard.co.uk/file-find-deprecated.diff > > It also patches everything else that touches File::Find, so the new > warning is suppressed for all the tests, and those tests that care > about exactly what warnings get spat at them still pass. I don't think it's a good idea to add a "don't do this warning" and then 26 "do as I say, not as I do" lines scattered across the core. If we're going to deprecate something, we need to stop using it in the core. Which would mean that we need an alternative in the core. Which would mean a bikeshed argument about what next. Nicholas ClarkThread Previous | Thread Next