develooper Front page | perl.perl5.porters | Postings from November 2008

Re: taint copying (was Re: 5.8.9/taint/NYTProf regression)

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
November 30, 2008 05:54
Subject:
Re: taint copying (was Re: 5.8.9/taint/NYTProf regression)
Message ID:
20081130135443.GP49335@plum.flirble.org
On Sun, Nov 30, 2008 at 01:09:37PM +0000, Nicholas Clark wrote:

> I don't fully understand what is going on. A lot of SVs with package names
> seem to end up tainted at times during compiling. However, in 5.8.8 (and

Taint gets added at the sv_catpvn of "::" here in Perl_yylex():

		    else {
			sv_setsv(PL_subname,PL_curstname);
			sv_catpvn(PL_subname,"::",2);
			sv_catpvn(PL_subname,tmpbuf,len);
		    }

So I'm starting to wonder if the code in Perl_leave_scope() that sets
PL_localizing = 2 is a hack to remove tainting that probably never should have
been there.

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About