develooper Front page | perl.perl5.porters | Postings from November 2008

Re: PATCH to CPAN.pm: some code, mostly doc

Thread Previous | Thread Next
From:
Tom Christiansen
Date:
November 23, 2008 21:32
Subject:
Re: PATCH to CPAN.pm: some code, mostly doc
Message ID:
2857.1227504749@chthon
>On Sun, Nov 23, 2008 at 7:43 PM, Tom Christiansen <tchrist@perl.com> wrote:
>> --- /home/tchrist/bleadperl/lib/CPAN.pm Wed Oct 29 13:23:40 2008
>> +++ /tmp/CPAN.pm        Sun Nov 23 17:30:44 2008

>Applied to trunk.  Notes that trunk now breaks out most of the CPAN
>packages so CPAN::Shell is now lib/CPAN/Shell.pm -- fortunately, all
>the rejected patch hunks for CPAN.pm applied cleanly to Shell.pm.  I
>tweaked one or two hunks (including fixing the CPANPLUS typo).  I spot
>checked many of them and they looked good -- but it was too much to
>read through every single one. That was a big job.  Thank you very
>much.

You're most welcome. 

Yes, it was *much* longer than I thought, but I didn't think it right to
quit partway.  However, I grew bleary-eyed by the end, sometimes unsure of
what Andreas trying to say.  Once I'd misread Disastrosaurus, I knew it was
time to hang it up. :-)

Another typo was here:

+Debugging this module is more than a bit complex duew to interference from

where "duew" should be written "due".  

And gosh, I *tried* debugging it, but since you couldn't simply 
import a debug pragma, was too lazy to set the variable and then 
attack it programmically.  Having all these programs tell me that 
they thought  http: was an invalid schema was rather unhelpful.  
I mean, like, did *you* immediately that extra space up there? :-)

Thanks for patching the right place for me.

--tom

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About