Front page | perl.perl5.porters |
Postings from November 2008
On Mon Jun 02 17:59:59 2008, GFUJI wrote:
> In fact, the second chunk of the patch is not necessarily needed, but
> it removes redundancy.
>
> (copied from the patch)
> 4588,4591c4588,4589
> < /* CRLF is unusual case - if this is just the :crlf layer pop it */
> < if (PerlIOBase(f)->tab == &PerlIO_crlf) {
> < PerlIO_pop(aTHX_ f);
> < }
> ---
> > /* CRLF is unusual case - pop it */
> > PerlIO_pop(aTHX_ f);
>
> The first chunk of the patch always guarantees PerlIOBase(f)->tab ==
> &PerlIO_crlf, so the validity check is unnecessary.
>
OK, I think the confusion was that the second part wasn't really related directly to the first
part. I have added the second part as change #34774. Thanks!
Steve Peters
Thread Previous