>>>>> On Fri, 31 Oct 2008 18:08:06 +0000, Nicholas Clark <nick@ccl4.org> said:
> There's something very wrong with the current CPAN.pm (1.9301).
Good catch.
I think the quickest fix is to set the default to connect-to-internet is OK
All other fixes would have too much impact for a last minute fix.
> Given that I'd like everything in place for 5.8.9-RC1 by, um, the weekend,
> if it's not trivial to fix reliably, then I'm going to have to revert back
> to 1.9205
I think this fix is reliable. I'll have to work on the branch of code
that deals with connect_to_internet_ok=0 but this won't be done by
today.
diff --git a/lib/CPAN/FirstTime.pm b/lib/CPAN/FirstTime.pm
index 9a79b5a..e8eb051 100644
--- a/lib/CPAN/FirstTime.pm
+++ b/lib/CPAN/FirstTime.pm
@@ -1198,7 +1198,7 @@ substitute. You can then revisit this dialog with
#= MIRRORED.BY and conf_sites()
#
- my_yn_prompt("connect_to_internet_ok" => 0, $matcher);
+ my_yn_prompt("connect_to_internet_ok" => 1, $matcher);
if ($matcher) {
if ("urllist" =~ $matcher) {
# conf_sites would go into endless loop with the smash prompt
Thanks,
--
andreas
Thread Previous
|
Thread Next