Front page | perl.perl5.porters |
Postings from May 2008
On May 4, 2008, at 5:04 AM, Rafael Garcia-Suarez wrote: > 2008/5/3 Jesse Vincent <jesse@fsck.com>: >> As I've been playing around with MAD this morning, I discovered a >> small >> issue with the way it does some of its xml dumping. The attached >> patch to >> dump.c improves this to use the entity encoder which was sitting >> there >> crying out for more attention. >> >> This is my first C patch to the core, so I'm sure I've done something >> not-quite-right. > > Yes :) > > You've patched against 5.10.0. The regexp structures have > significantly changed since 5.10, thanks to Nicholas -- they're now > first class. So that's one of the reasons why your patch doesn't > apply. > Right. Sorry. :) Lesson learned. (For the other patch I sent, it appears that 5.10.0 and blead had no changes inside mad/. Is there any reason to regen that one?) > The second one is that Gerard already fixed that bug, by this change : > I wish I'd had a copy of blead with me while I was offline hacking ;) > The third one is that your patch probably leaks a scalar (the 2nd > newSVpvn()). > *nod* > Sorry... There's no need to apologize. I appreciate the feedback. Best, JesseThread Previous | Thread Next