develooper Front page | perl.perl5.porters | Postings from June 2007

Re: [PATCH] Move the RXf_WHITE logic for split " " into the regex engine

Thread Previous
From:
demerphq
Date:
June 28, 2007 15:15
Subject:
Re: [PATCH] Move the RXf_WHITE logic for split " " into the regex engine
Message ID:
9b18b3110706281515p2194b753qacfebe50f840df4@mail.gmail.com
On 6/28/07, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
> This removes one of the more nasty warts in the API. C<split " ">
> would get the C<" "> turned into C<\s+> (and the SV* made RW) on the
> optree level to support C<split " ">. This adds RXf_SPLIT flag that's
> passed to the regex engine indicating that the pattern is part of a
> split statement. The regex engine then does all the work.
>
> Further info about the new API can be found in perlreapi.pod.
>
> B::Concise will run more tests as a result of RXf_SPLIT so the test
> count for it was increased.
>
> This passes all tests even though the C<" "> part of C<split " "> is
> not made into a !SvREADONLY scalar anymore. This appears to have been
> an artifact of the old (crazy) implementation which didn't harm
> anything else.

Thanks. Applied with a tweak as Change #31495.

Additional changes to eliminate the pattern parsing logic and replace
it with optree parsing logic were applied as Change #31496.

Cheers,
yves

-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About