develooper Front page | perl.perl5.porters | Postings from December 2005

Re: sprintf patches

Thread Previous | Thread Next
From:
Dominic Dunlop
Date:
December 10, 2005 13:20
Subject:
Re: sprintf patches
Message ID:
C84DCCCC-7009-4B97-B3E7-6B9B9DAEE6FC@mac.com
On 2005–12–10, at 14:07, Nicholas Clark wrote:
> Jarkko tells me that unified diffs aren't yet in POSIX, so context  
> diffs are
> likely to be more portable to older versions of patch.
>
> So, here we go again with another attempt...

Following results for Mac OS X 10.4.3 (Darwin 8.3.0)/gcc 4.0.1 with   
patch -p1 < sprintf.whatever; Configure -des; make test

perl-5.8.0: patched OK; unrelated compiler error in DB_File; all  
tests pass for  make minitest
perl-5.8.1: patched OK using sprintf-5.8.2 with offset of -15 in  
sv.c, otherwise directly; compiled OK without warnings; all tests pass.
perl-5.8.2: patched OK; compiled OK without warnings; all tests pass
perl-5.8.3: patched OK; compiled OK without warnings; all tests pass
perl-5.8.4-5.8.6: not tested
perl-5.8.7: patched OK; unrelated compiler warning in regcomp.c; all  
tests pass

Actually, "all tests pass" is a lie, but I've ignored the known (and  
recently "fixed") Mac OS X 10.4.x issue of "lib/ 
locale...........................FAILED at test 99".

The build errors for 5.8.0 are:

cc -c   -pipe -fno-common -no-cpp-precomp -fno-strict-aliasing -I/usr/ 
local/include -O3   -DVERSION=\"1.804\" -DXS_VERSION=\"1.804\"  "- 
I../.."   DB_File.c
DB_File.xs: In function 'ParseOpenInfo':
DB_File.xs:1370: warning: passing argument 2 of 'RETVAL->dbp->open'  
from incompatible pointer type
DB_File.xs:1370: error: incompatible type for argument 4 of 'RETVAL- 
 >dbp->open'
DB_File.xs:1370: error: too few arguments to function 'RETVAL->dbp- 
 >open'
make[1]: *** [DB_File.o] Error 1

The warning from regcomp.c for 5.8.7 is:

`sh  cflags "optimize='-O3'" regcomp.o`  regcomp.c
           CCCMD =  cc -DPERL_CORE -c -fno-common -DPERL_DARWIN -no- 
cpp-precomp -fno-strict-aliasing -pipe -I/usr/local/include -O3  -Wall
regcomp.c: In function 'S_study_chunk':
regcomp.c:734: warning: comparison is always false due to limited  
range of data type

Would it be useful for me to do Mac OS X 10.4.2 and/or gcc 3.3 as  
well? Threaded builds? Tomorrow.
-- 
Dominic Dunlop


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About