Front page | perl.perl5.porters |
Postings from December 2005
Re: sprintf patches
Thread Previous
|
Thread Next
From:
Brendan O'Dea
Date:
December 9, 2005 18:16
Subject:
Re: sprintf patches
Message ID:
20051210021549.GA28840@londo.c47.org
On Fri, Dec 09, 2005 at 09:40:24PM +0000, Nicholas Clark wrote:
>On Fri, Dec 09, 2005 at 08:06:56PM +0000, Nicholas Clark wrote:
>
>> Currently I'm very limited in what architectures I have access to - it would
>> be nice to have some feedback on whether they work perfectly on any OS other
>> than x86 FreeBSD 5.4 before I upload them to CPAN. (Given that CPAN only
>> gives me 1 shot at a name)
>
>I have brief feedback that they fail to apply to patchlevel.h on Solaris.
>I assume that this is because the Solaris patch doesn't like my edit to that
>hunk. If someone else has Solaris patch (or any other vendor patch) and can
>check, this would be useful.
That hunk fails on 5.8.7 using GNU patch (2.5.9) on Debian as well, both
in the uni and context diffs:
patching file patchlevel.h
Hunk #1 FAILED at 123.
1 out of 1 hunk FAILED -- saving rejects to file patchlevel.h.rej
Patch didn't seem to cope with the number of context lines above and
below varying. This works:
diff -u orig/patchlevel.h patched/patchlevel.h
--- orig/patchlevel.h 2005-12-10 12:35:10.000000000 +1100
+++ patched/patchlevel.h 2005-12-10 13:11:25.000000000 +1100
@@ -122,1 +122,2 @@
- ,NULL
+ ,"SPRINTF0 - fixes for sprintf formatting issues - CAN-2005-XXX"
+ ,NULL
and should cope with local patches within fuzz.
--bod
Thread Previous
|
Thread Next