develooper Front page | perl.perl5.porters | Postings from February 2001

Re: Patch 8715 does not apply cleanly

Thread Previous
From:
Gurusamy Sarathy
Date:
February 9, 2001 07:52
Subject:
Re: Patch 8715 does not apply cleanly
Message ID:
200102091552.f19Fq2x16428@smtp3.ActiveState.com
On Fri, 09 Feb 2001 12:14:18 GMT, Nick Ing-Simmons wrote:
>Andreas J . Koenig <andreas.koenig@anima.de> writes:
>>Patch  8715 complains
>>
>>    1 out of 1 hunk FAILED -- saving rejects to perl.c.rej
>>
>>and leaves this reject behind:
>>
>>So there seems to be a previous patch missing.
>
>I said:
>
><nick@ing-simmons.net> writes:
>>Doug Maceachern <dougm@covalent.net> writes:
>>>> It might be useful to split that into ptr_table_clear() and
>>>> ptr_table_free().
>>>
>>>ok, patch below should take care of both...
>>
>>In as Change 8713 - but note it needs 8715/8716 as well on non-ithreaded perl
>.
>
>That is the original change was 8713
>and 8715/8716 and then 8721 were needed to make it work
>(not one of my best efforts).
>
>For some reason 8713 has not shown up in 
>
>http://public.activestate.com/gsar/APC/5.7.1/diffs/

It's because the APC syncer ass_u_mes that all changes will be
checked in sequentially in change number order.  It isn't smart
enough to go back and fetch 8713 after it has fetched 8714 already,
and in this case 8714 might have been checked in before 8713 (perhaps
8713 was scheduled first, but checked it in after 8714).  8688 was
missing due to the same problem.

I've manually added the diffs (for the time being).


Sarathy
gsar@ActiveState.com

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About