develooper Front page | perl.perl5.changes | Postings from April 2008

Change 33707: Remove a dead case from the error reporting in

From:
Nicholas Clark
Date:
April 17, 2008 06:45
Subject:
Change 33707: Remove a dead case from the error reporting in
Change 33707 by nicholas@mouse-mill on 2008/04/17 13:36:21

	Remove a dead case from the error reporting in
	Perl_gv_fetchmethod_flags()

Affected files ...

... //depot/perl/gv.c#397 edit

Differences ...

==== //depot/perl/gv.c#397 (text) ====
Index: perl/gv.c
--- perl/gv.c#396~33706~	2008-04-17 05:47:39.000000000 -0700
+++ perl/gv.c	2008-04-17 06:36:21.000000000 -0700
@@ -624,6 +624,11 @@
 
     if (SvTYPE(stash) < SVt_PVHV)
 	stash = NULL;
+    else {
+	/* The only way stash can become NULL later on is if nsplit is set,
+	   which in turn means that there is no need for a SVt_PVHV case
+	   the error reporting code.  */
+    }
 
     for (nend = name; *nend; nend++) {
 	if (*nend == '\'') {
@@ -677,14 +682,9 @@
 		STRLEN packlen;
 		const char *packname;
 
-		assert(error_report);
-
 		if (nsplit) {
 		    packlen = nsplit - origname;
 		    packname = origname;
-		} else if (SvTYPE(error_report) == SVt_PVHV) {
-		    packlen = HvNAMELEN_get(error_report);
-		    packname = HvNAME_get(error_report);
 		} else {
 		    packname = SvPV_const(error_report, packlen);
 		}
End of Patch.



Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About