develooper Front page | perl.module.build.checkins | Postings from May 2008

[svn:Module-Build] r11191 - Module-Build/trunk/lib/Module/Build

From:
kwilliams
Date:
May 2, 2008 13:33
Subject:
[svn:Module-Build] r11191 - Module-Build/trunk/lib/Module/Build
Author: kwilliams
Date: Fri May  2 13:32:54 2008
New Revision: 11191

Modified:
   Module-Build/trunk/lib/Module/Build/Base.pm

Log:
We need to add 'use strict' in a couple of auto-generated methods, but actually that would break things in subtle ways, so I'm leaving it as-is for now

Modified: Module-Build/trunk/lib/Module/Build/Base.pm
==============================================================================
--- Module-Build/trunk/lib/Module/Build/Base.pm	(original)
+++ Module-Build/trunk/lib/Module/Build/Base.pm	Fri May  2 13:32:54 2008
@@ -696,6 +696,7 @@
         no strict 'refs';
 	if ( $type eq 'HASH' ) {
           *{"$class\::$property"} = sub {
+            # XXX this needs 'use strict' again
 	    my $self = shift;
 	    my $x = $self->{properties};
 	    return $x->{$property} unless @_;
@@ -719,6 +720,7 @@
 
         } else {
           *{"$class\::$property"} = sub {
+            # XXX this needs 'use strict' again
 	    my $self = shift;
 	    $self->{properties}{$property} = shift if @_;
 	    return $self->{properties}{$property};



Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About