HTML::Form bug

Hi all

I sent this to Gisle on 4 October but have had no reply. Thinking his
account may be whitelisted, I am posting it again here.


Since there are no bugs - even cleared ones - on the CPAN reporting
system for this module, I suspect it is best to mail you this bug report.

Method HTML::Form::FileInput::form_name_value has been changed so that
there is now a separate 'filename' field in the object. There is also
code, marked as legacy, handling the old way of doing things.
Unfortunately is is broken, and the problem has arisen from a query
regarding WWW::Mechanize which still uses this old method.

At the start, $filename is copied from the {filename} field of the
object, or from {value} if that field is empty. Later on in the legacy
code, line 1509, $fn is copied to $filename only if it is currently
undefined. Because the 'filename' method has defaulted it to the same
value as $file it will never be undefined at this point, and can be an
array reference if the old call method is used, giving actual an actual
value in the HTTP::Request of something like "ARRAY(0x9567570)".

All that seems to be necessary to fix the problem is to remove the line

   $old = $self->file unless defined $old;

from the 'filename' method.

Cheers,

Rob Dixon

• HTML::Form bug by Rob Dixon
• Re: HTML::Form bug by Gisle Aas
• Re: HTML::Form bug by Rob Dixon